Bowrna commented on code in PR #31996:
URL: https://github.com/apache/airflow/pull/31996#discussion_r1268938486
##########
airflow/jobs/job.py:
##########
@@ -207,7 +207,16 @@ def heartbeat(
self.log.debug("[heartbeat]")
except OperationalError:
Stats.incr(convert_camel_to_snake(self.__class__.__name__) +
"_heartbeat_failure", 1, 1)
- self.log.exception("%s heartbeat got an exception",
self.__class__.__name__)
+ if self.is_alive():
+ self.log.error(
+ "%s heartbeat failed with error. Scheduler may go into
unhealthy state",
+ self.__class__.__name__,
+ )
+ else:
+ self.log.error(
+ "%s heartbeat failed with error. Scheduler is in unhealthy
state", self.__class__.__name__
+ )
Review Comment:
I have checked #32586 thanks @potiuk @BShraman I would like to hear from you
on how the logging can be improved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
