potiuk commented on code in PR #33439:
URL: https://github.com/apache/airflow/pull/33439#discussion_r1296735704


##########
dev/breeze/src/airflow_breeze/provider_issue_TEMPLATE.md.jinja2:
##########
@@ -1,6 +1,10 @@
 I have a kind request for all the contributors to the latest provider packages 
release.
 Could you please help us to test the RC versions of the providers?
 
+The guidelines on how to test providers can be found in
+
+[Verify providers by 
contributors](https://github.com/apache/airflow/blob/main/dev/README_RELEASE_PROVIDER_PACKAGES.md#verify-the-release-candidate-by-contributors)

Review Comment:
   > Yeah totally separate PR.
   > 
   > yes, we should have explnation of what we want to do, why we are doing it 
and how to actually do it.
   > 
   > I think ideally breeze should handle it by it's own (thus making the 
paragraph we want to introduce now redundant) Something like:
   > 
   > ```
   > breeze start-airflow --use-airflow-version 2.2.4 --python 3.8 --backend 
postgres \
   >     --load-example-dags --load-default-connections 
--override-default-provider-versions apache-airflow-providers-amazon==10.10.0rc1
   > ```
   > 
   > but that is a feature request for later.
   
   Indeed - this precisely what I improved for Airflow recently (and I think it 
has all the aspects of what you are talking about @eladkal). It would be great 
if someone takes it as an example and distills that into better instructions if 
the current provider's ones are not good enough. Other than correcting the 
strange sentence I am not sure how to enhance current instructions, though? 
   
   Maybe someone could create a PR with better description and we could iterate 
on it to make it clearer ? I am not sure how to more describe the whys and 
whether the current provider instructions fail to deliver on that @eladkal ?
   
   For the reference this is the current description for Airflow.
   
   > Verify the release candidate by Contributors
   > This can be done (and we encourage to) by any of the Contributors. In 
fact, it's best if the actual users of Apache Airflow test it in their own 
staging/test installations. Each release candidate is available on PyPI apart 
from SVN packages, so everyone should be able to install the release candidate 
version.
   >
   > But you can use any of the installation methods you prefer (you can even 
install it via the binary wheels downloaded from the SVN).
   >
   > Installing release candidate in your local virtual environment
   > pip install apache-airflow==<VERSION>rc<X>
   > Optionally it can be followed with constraints
   
   > pip install apache-airflow==<VERSION>rc<X> \
   >   --constraint 
"https://raw.githubusercontent.com/apache/airflow/constraints-<VERSION>/constraints-3.8.txt"`
   > Note that the constraints contain python version that you are installing 
it with.
   
   > You can use any of the installation methods you prefer (you can even 
install it via the binary wheel downloaded from the SVN).
   
   > There is also an easy way of installation with Breeze if you have the 
latest sources of Apache Airflow. Running the following command will use tmux 
inside breeze, create admin user and run Webserver & Scheduler:
   
   > breeze start-airflow --use-airflow-version 2.7.0rc1 --python 3.8 --backend 
postgres
   > You can also choose different executors and extras to install when you are 
installing airflow this way. For example in > order to run Airflow with 
CeleryExecutor and install celery, google and amazon provider (as of Airflow 
2.7.0, you need > to have celery provider installed to run Airflow with 
CeleryExecutor) you can run:
   
   > breeze start-airflow --use-airflow-version 2.7.0rc1 --python 3.8 --backend 
postgres \
   >   --executor CeleryExecutor --airflow-extras "celery,google,amazon"
   > Once you install and run Airflow, you should perform any verification you 
see as necessary to check that the Airflow works as you expected.
   
   ```
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to