Bisk1 commented on PR #33746: URL: https://github.com/apache/airflow/pull/33746#issuecomment-1694701129
@potiuk I was trying to follow your suggestion and wanted to modify API until I found another issue: `SHUTDOWN` state was never added to API spec - the enum for TaskState in v1.yaml doesn't have it. https://github.com/apache/airflow/blob/f9276f0597d5ad91c98d0db36d16d799ee2d4f21/airflow/api_connexion/openapi/v1.yaml#L4684-L4697 I tested querying a `SHUTDOWN` task as above on main branch and 500 error is also reproduced there. Do you think I should fix it and add `SHUTDOWN` to spec for sake of handling historical tasks? Because it seems that we could simply take advantage of the fact that it was never handled properly in API (and nobody reported bug) and remove it from the code silently. You can't break something that didn't exist 😄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
