uranusjr commented on code in PR #33746:
URL: https://github.com/apache/airflow/pull/33746#discussion_r1307021602
##########
tests/cli/commands/test_jobs_command.py:
##########
@@ -109,7 +109,7 @@ def test_should_ignore_not_running_jobs(self):
for _ in range(3):
scheduler_job = Job()
job_runner = SchedulerJobRunner(job=scheduler_job)
- scheduler_job.state = State.SHUTDOWN
+ scheduler_job.state = State.FAILED
Review Comment:
Let’s change these `State` references to strong typed enum (e.g. `JobState`
for this instance) while we’re at it.
##########
tests/cli/commands/test_jobs_command.py:
##########
@@ -109,7 +109,7 @@ def test_should_ignore_not_running_jobs(self):
for _ in range(3):
scheduler_job = Job()
job_runner = SchedulerJobRunner(job=scheduler_job)
- scheduler_job.state = State.SHUTDOWN
+ scheduler_job.state = State.FAILED
Review Comment:
Let’s change these `State` references to strong typed enum (e.g. `JobState`
for this instance) while we’re at it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
