vandonr-amz commented on code in PR #33901: URL: https://github.com/apache/airflow/pull/33901#discussion_r1310547795
########## airflow/www/security_manager.py: ########## @@ -0,0 +1,759 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +import warnings +from typing import TYPE_CHECKING, Any, Collection, Container, Iterable, Sequence + +from flask import g +from sqlalchemy import or_, select +from sqlalchemy.orm import joinedload + +from airflow.auth.managers.fab.models import Permission, Resource, Role, User +from airflow.auth.managers.fab.views.permissions import ( + ActionModelView, + PermissionPairModelView, + ResourceModelView, +) +from airflow.auth.managers.fab.views.roles_list import CustomRoleModelView +from airflow.auth.managers.fab.views.user import ( + CustomUserDBModelView, + CustomUserLDAPModelView, + CustomUserOAuthModelView, + CustomUserOIDModelView, + CustomUserRemoteUserModelView, +) +from airflow.auth.managers.fab.views.user_edit import ( + CustomResetMyPasswordView, + CustomResetPasswordView, + CustomUserInfoEditView, +) +from airflow.auth.managers.fab.views.user_stats import CustomUserStatsChartView +from airflow.exceptions import AirflowException, RemovedInAirflow3Warning +from airflow.models import DagBag, DagModel +from airflow.security import permissions +from airflow.utils.log.logging_mixin import LoggingMixin +from airflow.utils.session import NEW_SESSION, provide_session +from airflow.www.extensions.init_auth_manager import get_auth_manager +from airflow.www.fab_security.sqla.manager import SecurityManager +from airflow.www.utils import CustomSQLAInterface + +EXISTING_ROLES = { + "Admin", + "Viewer", + "User", + "Op", + "Public", +} + +if TYPE_CHECKING: + from sqlalchemy.orm import Session + + +class AirflowSecurityManager(SecurityManager, LoggingMixin): Review Comment: I'm thinking of renaming this one, like, `AirflowSecurityManager2` or something, because differentiating only by the imports makes the code very hard to read... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
