Taragolis commented on code in PR #33952:
URL: https://github.com/apache/airflow/pull/33952#discussion_r1311457661
##########
airflow/providers/amazon/aws/triggers/emr.py:
##########
@@ -242,7 +242,7 @@ def __init__(
)
def hook(self) -> AwsGenericHook:
- return EmrContainerHook(self.aws_conn_id)
+ return EmrContainerHook(aws_conn_id=self.aws_conn_id)
Review Comment:
Nice catch, hooks are mixed with positional/keyword arguments, and this
might lead a problem when we create Thick wrapper hook
https://github.com/apache/airflow/blob/633217c84217f925c4c0a92e0b24ba314b64281b/airflow/providers/amazon/aws/hooks/emr.py#L53-L58
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]