Taragolis commented on code in PR #33952:
URL: https://github.com/apache/airflow/pull/33952#discussion_r1312028756
##########
airflow/providers/amazon/aws/triggers/emr.py:
##########
@@ -242,7 +242,7 @@ def __init__(
)
def hook(self) -> AwsGenericHook:
- return EmrContainerHook(self.aws_conn_id)
+ return EmrContainerHook(aws_conn_id=self.aws_conn_id)
Review Comment:
For this case we usually decorate it as `@cahed_property`. In general it
uses in a lot of places over the different providers, especially when you need
to move something heavy from constructor and keep compatible attribute.
Anyway it was just a question, no offence
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]