[GitHub] [airflow] Taragolis commented on a diff in pull request #34119: Make sure that only valid elasticsearch keys are passed to handler

[via GitHub]

Taragolis commented on code in PR #34119:
URL: https://github.com/apache/airflow/pull/34119#discussion_r1316345822


##########
airflow/providers/elasticsearch/log/es_task_handler.py:
##########
@@ -56,6 +57,23 @@
 USE_PER_RUN_LOG_ID = hasattr(DagRun, "get_log_template")
 
 
+# These are the only keys that are allowed in the elasticsearch_configs section
+# This should be synchronized with config section in provider.yaml
+VALID_ES_CONFIG_KEYS = {
+    "http_compress",
+    "verify_certs",
+}

Review Comment:
   I've just worry that this allow-list could also breaks users pipelines.
   
   For example @cesar-vermeulen 's config contains additional values
   
   ```ini
   [elasticsearch_configs]
   max_retries = 3
   retry_timeout = True
   timeout = 30
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org