Taragolis commented on code in PR #34119:
URL: https://github.com/apache/airflow/pull/34119#discussion_r1316364199
##########
airflow/providers/elasticsearch/log/es_task_handler.py:
##########
@@ -56,6 +57,23 @@
USE_PER_RUN_LOG_ID = hasattr(DagRun, "get_log_template")
+# These are the only keys that are allowed in the elasticsearch_configs section
+# This should be synchronized with config section in provider.yaml
+VALID_ES_CONFIG_KEYS = {
+ "http_compress",
+ "verify_certs",
+}
Review Comment:
BTW, I've found yesterday that we have [`[logging]
remote_task_handler_kwargs`
](https://airflow.apache.org/docs/apache-airflow/stable/configurations-ref.html#remote-task-handler-kwargs)
in the first glance it is good candidate to replace entire
`elasticsearch_configs` config section in case of Airflow 2.6+ so user could
provide additional `kwargs` by this parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
