jedcunningham commented on code in PR #34342:
URL: https://github.com/apache/airflow/pull/34342#discussion_r1325017457
##########
chart/templates/_helpers.yaml:
##########
@@ -198,51 +198,49 @@ If release name contains chart name it will be used as a
full name.
securityContext: {{- include "localContainerSecurityContext"
.Values.dags.gitSync | nindent 4 }}
env:
{{- if .Values.dags.gitSync.sshKeySecret }}
- - name: GIT_SSH_KEY_FILE
+ - name: GITSYNC_SSH_KEY_FILE
value: "/etc/git-secret/ssh"
- - name: GIT_SYNC_SSH
+ - name: GITSYNC_SSH
value: "true"
{{- if .Values.dags.gitSync.knownHosts }}
- - name: GIT_KNOWN_HOSTS
+ - name: GITSYNC_SSH_KNOWN_HOSTS
value: "true"
- - name: GIT_SSH_KNOWN_HOSTS_FILE
+ - name: GITSYNC_SSH_KNOWN_HOSTS_FILE
value: "/etc/git-secret/known_hosts"
{{- else }}
- - name: GIT_KNOWN_HOSTS
+ - name: GITSYNC_SSH_KNOWN_HOSTS
value: "false"
{{- end }}
{{ else if .Values.dags.gitSync.credentialsSecret }}
- - name: GIT_SYNC_USERNAME
+ - name: GITSYNC_USERNAME
valueFrom:
secretKeyRef:
name: {{ .Values.dags.gitSync.credentialsSecret | quote }}
- key: GIT_SYNC_USERNAME
- - name: GIT_SYNC_PASSWORD
+ key: GITSYNC_USERNAME
Review Comment:
We can't just change what key we use like this, another breaking change.
##########
chart/values.schema.json:
##########
@@ -7169,10 +7164,10 @@
"type": "string",
"default": "tests/dags"
},
- "wait": {
+ "period": {
"description": "Interval between git sync attempts
in seconds. High values are more likely to cause DAGs to become out of sync
between different components. Low values cause more traffic to the remote git
repository.",
- "type": "integer",
- "default": 5
+ "type": "string",
+ "default": "5s"
Review Comment:
This change concerns me though. Maybe we can continue to use the wait env
var so we can use the float seconds path instead?
##########
chart/values.schema.json:
##########
@@ -7169,10 +7164,10 @@
"type": "string",
"default": "tests/dags"
},
- "wait": {
+ "period": {
Review Comment:
This is also a breaking change - we'd need to support both if we do the
rename.
##########
airflow/providers/cncf/kubernetes/pod_template_file_examples/git_sync_template.yaml:
##########
@@ -26,21 +26,21 @@ metadata:
spec:
initContainers:
- name: git-sync
- image: "registry.k8s.io/git-sync/git-sync:v3.6.3"
+ image: "registry.k8s.io/git-sync/git-sync:v4.0.0"
env:
- - name: GIT_SYNC_BRANCH
+ - name: GITSYNC_REF
Review Comment:
As much as I don't want to say it, I think we need to set both the old and
new styles. If folks have existing <v4 images mirrored this will break.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
