mnacharov commented on code in PR #34342:
URL: https://github.com/apache/airflow/pull/34342#discussion_r1326117017
##########
chart/templates/_helpers.yaml:
##########
@@ -198,51 +198,49 @@ If release name contains chart name it will be used as a
full name.
securityContext: {{- include "localContainerSecurityContext"
.Values.dags.gitSync | nindent 4 }}
env:
{{- if .Values.dags.gitSync.sshKeySecret }}
- - name: GIT_SSH_KEY_FILE
+ - name: GITSYNC_SSH_KEY_FILE
value: "/etc/git-secret/ssh"
- - name: GIT_SYNC_SSH
+ - name: GITSYNC_SSH
value: "true"
{{- if .Values.dags.gitSync.knownHosts }}
- - name: GIT_KNOWN_HOSTS
+ - name: GITSYNC_SSH_KNOWN_HOSTS
value: "true"
- - name: GIT_SSH_KNOWN_HOSTS_FILE
+ - name: GITSYNC_SSH_KNOWN_HOSTS_FILE
value: "/etc/git-secret/known_hosts"
{{- else }}
- - name: GIT_KNOWN_HOSTS
+ - name: GITSYNC_SSH_KNOWN_HOSTS
value: "false"
{{- end }}
{{ else if .Values.dags.gitSync.credentialsSecret }}
- - name: GIT_SYNC_USERNAME
+ - name: GITSYNC_USERNAME
valueFrom:
secretKeyRef:
name: {{ .Values.dags.gitSync.credentialsSecret | quote }}
- key: GIT_SYNC_USERNAME
- - name: GIT_SYNC_PASSWORD
+ key: GITSYNC_USERNAME
Review Comment:
I think that this breaking change must be made by anyone who wants to use
git-sync v4.0.0+, but we can keep git-sync tag =~v3.9 in chart's values.yaml.
but for those who put v4.0.0+ in their values file it's necessary to upgrade
their credentialsSecret as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
