hussein-awala commented on code in PR #34359:
URL: https://github.com/apache/airflow/pull/34359#discussion_r1326400658
##########
airflow/operators/python.py:
##########
@@ -547,14 +547,20 @@ def __init__(
):
if (
python_version
- and str(python_version)[0] != str(sys.version_info.major)
+ and str(python_version[0]) != str(sys.version_info.major)
Review Comment:
To deprecate a type, you need to keep it backward compatible. This is a
breaking change for int/float values, where we cannot subscript a numeric
value. Actually there is no need for this change, the current code works for
both numerical and sting versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
