potiuk commented on code in PR #34359:
URL: https://github.com/apache/airflow/pull/34359#discussion_r1326982950
##########
airflow/operators/python.py:
##########
@@ -555,6 +555,13 @@ def __init__(
"major versions for PythonVirtualenvOperator. Please use
string_args."
f"Sys version: {sys.version_info}. Venv version:
{python_version}"
)
+ if type(python_version) is float or type(python_version) is int:
+ warnings.warn(
+ "Passing numeric type(int, float) as python_version is
deprecated. "
+ "Please use string value instead.",
+ RemovedInAirflow3Warning,
+ stacklevel=2,
+ )
Review Comment:
Yep. Also using type(object) is generally suspicious. In this case int/float
cannot be extended, so no difference, but generally using type rather than
isinstance is a code smell.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
