jedcunningham commented on code in PR #34342:
URL: https://github.com/apache/airflow/pull/34342#discussion_r1337852570
##########
chart/templates/_helpers.yaml:
##########
@@ -197,6 +197,7 @@ If release name contains chart name it will be used as a
full name.
imagePullPolicy: {{ .Values.images.gitSync.pullPolicy }}
securityContext: {{- include "localContainerSecurityContext"
.Values.dags.gitSync | nindent 4 }}
env:
+ {{- if semverCompare "<4.0.0" .Values.images.gitSync.tag }}
Review Comment:
Moving @hussein-awala's question here from a resolved thread, I'd say that
will dictate whether the old + new approach is palatable:
> Will we have deprecation warning if we provide both old and new styles to
git-sync v4.0.0+ image?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
