Xiroo commented on PR #34715: URL: https://github.com/apache/airflow/pull/34715#issuecomment-1743440172
I changed to use 'timeout' parameter. I think I don't have to make this parameter optional since baseoperator has default value of it https://github.com/apache/airflow/blob/6618c5f90d037d57e9f3bf1e90cd0712426d6caa/airflow/sensors/base.py#L138 and have validating logic to have int or float https://github.com/apache/airflow/blob/6618c5f90d037d57e9f3bf1e90cd0712426d6caa/airflow/sensors/base.py#L185-L186 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
