hussein-awala commented on code in PR #34785:
URL: https://github.com/apache/airflow/pull/34785#discussion_r1347968624
##########
airflow/providers/google/cloud/hooks/dataflow.py:
##########
@@ -420,7 +420,9 @@ def _check_dataflow_job_state(self, job) -> bool:
"JOB_STATE_DRAINED while it is a batch job"
)
- if not self._wait_until_finished and current_state ==
self._expected_terminal_state:
+ if current_state == self._expected_terminal_state:
+ if self._expected_terminal_state ==
DataflowJobStatus.JOB_STATE_RUNNING:
+ return not self._wait_until_finished
Review Comment:
I never used this operator, but I wonder what is `_expected_terminal_state`
and why we may return False if `_wait_until_finished` is set the True and the
state is equals to the provided expected terminal state :thinking:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
