champon1020 commented on code in PR #34785:
URL: https://github.com/apache/airflow/pull/34785#discussion_r1348070993
##########
airflow/providers/google/cloud/hooks/dataflow.py:
##########
@@ -420,7 +420,9 @@ def _check_dataflow_job_state(self, job) -> bool:
"JOB_STATE_DRAINED while it is a batch job"
)
- if not self._wait_until_finished and current_state ==
self._expected_terminal_state:
+ if current_state == self._expected_terminal_state:
+ if self._expected_terminal_state ==
DataflowJobStatus.JOB_STATE_RUNNING:
+ return not self._wait_until_finished
Review Comment:
> why we may return False if _wait_until_finished is set the True and the
state is equals to the provided expected terminal state
Based on the above, this is because `_wait_until_finished` was applied
preferentially compared to `_expected_terminal_state` in the original
implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
