uranusjr commented on code in PR #34791:
URL: https://github.com/apache/airflow/pull/34791#discussion_r1354536429
##########
airflow/cli/commands/variable_command.py:
##########
@@ -61,8 +61,8 @@ def variables_get(args):
@cli_utils.action_cli
@providers_configuration_loaded
def variables_set(args):
- """Create new variable with a given name and value."""
- Variable.set(args.key, args.value, serialize_json=args.json)
+ """Create new variable with a given name, value and description."""
+ Variable.set(args.key, args.value, args.description or None,
serialize_json=args.json)
Review Comment:
```suggestion
Variable.set(args.key, args.value, args.description,
serialize_json=args.json)
```
I’d assume the user would have a use case if they explicitly supply an empty
string.
##########
airflow/cli/commands/variable_command.py:
##########
@@ -61,8 +61,8 @@ def variables_get(args):
@cli_utils.action_cli
@providers_configuration_loaded
def variables_set(args):
- """Create new variable with a given name and value."""
- Variable.set(args.key, args.value, serialize_json=args.json)
+ """Create new variable with a given name, value and description."""
+ Variable.set(args.key, args.value, args.description or None,
serialize_json=args.json)
Review Comment:
```suggestion
Variable.set(args.key, args.value, args.description,
serialize_json=args.json)
```
I’d assume the user would have a use case if they explicitly supply an empty
string.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
