Zhenye-Na commented on code in PR #34791:
URL: https://github.com/apache/airflow/pull/34791#discussion_r1359746101
##########
tests/cli/commands/test_variable_command.py:
##########
@@ -49,6 +49,15 @@ def test_variables_set(self):
with pytest.raises(KeyError):
Variable.get("foo1")
+ def test_variables_set_with_description(self):
+ """Test variable_set command with optional description argument"""
+ variable_command.variables_set(
+ self.parser.parse_args(["variables", "set", "foo", "bar",
"--description", "foo_bar_description"])
+ )
+ assert Variable.get("foo") is not None
Review Comment:
I am not able to find an existing method to retrieve the variable's
`description` in
https://github.com/apache/airflow/blob/main/airflow/models/variable.py, should
this be considered as a follow up PR with a issue to support this feature ?
Similar to this, I think the CLI command for `variable set` does not contain
description as a valid output as well.
Please let me know if you or the team would like to create a dedicated issue
to support this feature.
But for this PR, I am inclined to skip this check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
