potiuk commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1355974367
##########
airflow/api_connexion/security.py:
##########
@@ -48,10 +61,194 @@ def requires_access_decorator(func: T):
@wraps(func)
def decorated(*args, **kwargs):
check_authentication()
- if appbuilder.sm.check_authorization(permissions,
kwargs.get("dag_id")):
+ if appbuilder.sm.check_authorization(permissions):
Review Comment:
1. Should we raise deprecation warning if the decorator is used by someone?
2. Should we raise exception here if auth_manager is not FAB in case we run
a function decorated with it?
This would give people indication that if they want to use their own
plugins, they should switch to the other methods.
We could also make a copy of that decorator in FAB auth manager and make
sure that all the remaining Airflow embeded APIs (user/roles) do not raise
deprecation warnings. Those are just a few lines to copy but this way only
user's code would generate deprecation warnings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
