vincbeck commented on code in PR #34317:
URL: https://github.com/apache/airflow/pull/34317#discussion_r1357126074
##########
airflow/api_connexion/security.py:
##########
@@ -48,10 +61,194 @@ def requires_access_decorator(func: T):
@wraps(func)
def decorated(*args, **kwargs):
check_authentication()
- if appbuilder.sm.check_authorization(permissions,
kwargs.get("dag_id")):
+ if appbuilder.sm.check_authorization(permissions):
Review Comment:
I was thinking removing this one once the user and roles endpoints have been
migrated but I guess it is the same case as `has_access` decorator and we
should keep it. I will:
- Raise a deprecation warning when used
- Copy it to the FAB auth manager and call this one from the one above
> Should we raise exception here if auth_manager is not FAB in case we run a
function decorated with it?
I really want to avoid doing `if not isistance(auth_manager, FabAuthManager`
as much as possible. I think deprecation warnings are enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
