Taragolis commented on code in PR #34884:
URL: https://github.com/apache/airflow/pull/34884#discussion_r1356690252
##########
tests/providers/amazon/aws/triggers/test_base.py:
##########
@@ -63,10 +63,33 @@ def test_region_serialized(self):
assert "region_name" in args
assert args["region_name"] == "my_region"
- def test_region_not_serialized_if_omitted(self):
+ @pytest.mark.parametrize("verify", [True, False,
pytest.param("/foo/bar.pem", id="path")])
+ def test_verify_serialized(self, verify):
+ self.trigger.verify = verify
_, args = self.trigger.serialize()
- assert "region_name" not in args
+ assert "verify" in args
+ assert args["verify"] == verify
+
+ @pytest.mark.parametrize(
+ "botocore_config",
+ [
+ pytest.param({"read_timeout": 10, "connect_timeout": 42,
"keepalive": True}, id="non-empty-dict"),
Review Comment:
Yeah we could create page for base boto3 based operators.
However I think that we also need to have this kind of documentation into
the specific operators pages. Because from [auto-API
pages](https://airflow.apache.org/docs/apache-airflow-providers-amazon/stable/_api/airflow/providers/amazon/aws/operators/lambda_function/index.html#airflow.providers.amazon.aws.operators.lambda_function.LambdaInvokeFunctionOperator)
users would go to the operator specific page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
