Taragolis commented on code in PR #34884:
URL: https://github.com/apache/airflow/pull/34884#discussion_r1356922790
##########
airflow/providers/amazon/aws/triggers/base.py:
##########
@@ -102,9 +109,15 @@ def serialize(self) -> tuple[str, dict[str, Any]]:
},
**self.serialized_fields,
)
+
+ # if we serialize the None value from this, it breaks subclasses that
don't have it in their ctor.
if self.region_name:
- # if we serialize the None value from this, it breaks subclasses
that don't have it in their ctor.
params["region_name"] = self.region_name
+ if self.verify is not None:
+ params["verify"] = self.verify
+ if self.botocore_config is not None:
+ params["botocore_config"] = self.botocore_config
Review Comment:
Yeah, makes sense.
It is a bit change behaviour for `region_name` because right now
`region_name=""` also excluded however I think it is edge case, because empty
string it is invalid argument for boto3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
