Taragolis commented on code in PR #34966:
URL: https://github.com/apache/airflow/pull/34966#discussion_r1360827505
##########
airflow/providers/amazon/aws/operators/eks.py:
##########
@@ -397,10 +397,10 @@ def deferrable_create_cluster_next(self, context:
Context, event: dict[str, Any]
)
def execute_failed(self, context: Context, event: dict[str, Any] | None =
None) -> None:
- if event is None:
- self.log.info("Trigger error: event is None")
- raise AirflowException("Trigger error: event is None")
- elif event["status"] == "delteted":
+ if event is None or event["status"] != "deleted":
+ self.log.info("Trigger error: event is %s", event)
+ raise AirflowException(f"Trigger error: event is {event}")
Review Comment:
The problem here, that delete it is teardown in case of error happen during
cluster creation.
But cluster delete itself is not an original cause of issue.
##########
airflow/providers/amazon/aws/operators/eks.py:
##########
@@ -397,10 +397,10 @@ def deferrable_create_cluster_next(self, context:
Context, event: dict[str, Any]
)
def execute_failed(self, context: Context, event: dict[str, Any] | None =
None) -> None:
- if event is None:
- self.log.info("Trigger error: event is None")
- raise AirflowException("Trigger error: event is None")
- elif event["status"] == "delteted":
+ if event is None or event["status"] != "deleted":
+ self.log.info("Trigger error: event is %s", event)
+ raise AirflowException(f"Trigger error: event is {event}")
+ else:
self.log.info("Cluster deleted")
raise event["exception"]
Review Comment:
I've just wondering what is the source of "exception", because it should
return this object ideally
https://github.com/apache/airflow/blob/609eed90698aa7abeb5bae9ae156062d32baae86/airflow/providers/amazon/aws/triggers/eks.py#L139
And for me it `else` branch is unreachable right now, but maybe I miss
something
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
