theaadya commented on code in PR #34966:
URL: https://github.com/apache/airflow/pull/34966#discussion_r1361522739
##########
airflow/providers/amazon/aws/operators/eks.py:
##########
@@ -397,10 +397,10 @@ def deferrable_create_cluster_next(self, context:
Context, event: dict[str, Any]
)
def execute_failed(self, context: Context, event: dict[str, Any] | None =
None) -> None:
- if event is None:
- self.log.info("Trigger error: event is None")
- raise AirflowException("Trigger error: event is None")
- elif event["status"] == "delteted":
+ if event is None or event["status"] != "deleted":
+ self.log.info("Trigger error: event is %s", event)
+ raise AirflowException(f"Trigger error: event is {event}")
+ else:
self.log.info("Cluster deleted")
raise event["exception"]
Review Comment:
I'm working on writing some unit tests to test the working of the method
(new to Airflow, so it's a learning curve)
##########
airflow/providers/amazon/aws/operators/eks.py:
##########
@@ -397,10 +397,10 @@ def deferrable_create_cluster_next(self, context:
Context, event: dict[str, Any]
)
def execute_failed(self, context: Context, event: dict[str, Any] | None =
None) -> None:
- if event is None:
- self.log.info("Trigger error: event is None")
- raise AirflowException("Trigger error: event is None")
- elif event["status"] == "delteted":
+ if event is None or event["status"] != "deleted":
+ self.log.info("Trigger error: event is %s", event)
+ raise AirflowException(f"Trigger error: event is {event}")
Review Comment:
Can you clarify a little more on the issue faced and give any suggestions on
how to tackle it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
