ferruzzi commented on code in PR #35037:
URL: https://github.com/apache/airflow/pull/35037#discussion_r1367326682
##########
airflow/providers/amazon/aws/hooks/s3.py:
##########
@@ -912,14 +912,24 @@ def get_key(self, key: str, bucket_name: str | None =
None) -> S3ResourceObject:
:param bucket_name: the name of the bucket
:return: the key object from the bucket
"""
+
+ def __sanitize_extra_args() -> dict[str, str]:
Review Comment:
ehhhhh. I saw someone mentioning that a dunder was a growing convention
for "really, this is private don't use it" and some IDEs have started enforcing
that, but maybe I shouldn't use it here. Happy to revert it if we don't like
it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
