uranusjr commented on code in PR #35037:
URL: https://github.com/apache/airflow/pull/35037#discussion_r1368327181
##########
airflow/providers/amazon/aws/hooks/s3.py:
##########
@@ -912,14 +912,24 @@ def get_key(self, key: str, bucket_name: str | None =
None) -> S3ResourceObject:
:param bucket_name: the name of the bucket
:return: the key object from the bucket
"""
+
+ def __sanitize_extra_args() -> dict[str, str]:
Review Comment:
Conventions vary for function-local functions, but I don’t think double
underscore is one of them. Either single or no leading underscores is fine.
##########
airflow/providers/amazon/aws/hooks/s3.py:
##########
@@ -912,14 +912,24 @@ def get_key(self, key: str, bucket_name: str | None =
None) -> S3ResourceObject:
:param bucket_name: the name of the bucket
:return: the key object from the bucket
"""
+
+ def __sanitize_extra_args() -> dict[str, str]:
Review Comment:
Conventions vary for function-local functions, but I don’t think double
underscore is one of them. Either single or no leading underscores is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
