potiuk commented on code in PR #34945:
URL: https://github.com/apache/airflow/pull/34945#discussion_r1368935064
##########
airflow/cli/commands/celery_command.py:
##########
@@ -68,28 +67,7 @@ def flower(args):
if args.flower_conf:
options.append(f"--conf={args.flower_conf}")
- if args.daemon:
- pidfile, stdout, stderr, _ = setup_locations(
- process="flower",
- pid=args.pid,
- stdout=args.stdout,
- stderr=args.stderr,
- log=args.log_file,
- )
- with open(stdout, "a") as stdout, open(stderr, "a") as stderr:
- stdout.truncate(0)
- stderr.truncate(0)
-
- ctx = daemon.DaemonContext(
- pidfile=TimeoutPIDLockFile(pidfile, -1),
- stdout=stdout,
- stderr=stderr,
- umask=int(settings.DAEMON_UMASK, 8),
- )
- with ctx:
- celery_app.start(options)
- else:
- celery_app.start(options)
+ run_command_with_daemon_mode(args, "flower", lambda:
celery_app.start(options))
Review Comment:
```suggestion
run_command_with_daemon_option(args, "flower", lambda:
celery_app.start(options))
```
Maybe? The name suggest that it's always daemon but it is based on
args.daemon .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
