Bisk1 commented on code in PR #34945:
URL: https://github.com/apache/airflow/pull/34945#discussion_r1369154410
##########
airflow/cli/commands/internal_api_command.py:
##########
@@ -148,60 +139,54 @@ def kill_proc(signum, _):
gunicorn_master_proc.kill()
sys.exit(0)
- def monitor_gunicorn(gunicorn_master_pid: int):
+ def monitor_gunicorn(gunicorn_master_proc: psutil.Process |
subprocess.Popen):
Review Comment:
add typing; turns out there was some error in code that I fixed by
copying&pasting the same section from webserver_command.py (BTW these 2 files
have a lot of duplication so could use more refactoring)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
