vincbeck commented on PR #35163: URL: https://github.com/apache/airflow/pull/35163#issuecomment-1777804841
Interesting! I am divided on this one to be honest. 1. I like the fact to try to normalize all hooks within the Amazon provider package. I agree that contributors, who might not be very used to the notion of hooks, may pass all arguments to the `__init__` instead of appropriate methods. This should prevent this. 2. I am scared that it would make it more complicated to contribute to the Amazon provider package, that is the opposite of what we want 3. When I see the pros and the cons, I am wondering if adding this added complexity is worth it My 2c -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
