o-nikolas commented on PR #35163:
URL: https://github.com/apache/airflow/pull/35163#issuecomment-1778007125

   > I have a look in detail on listed hook and some of them created on Airflow 
1.10.0, some other migrated from old `boto` to `boto3` in the period of airflow 
1.8 - 1.10 (s3/dynamodb)
   > 
   > Personally for me I think it is better to have this hooks looks similar as 
well as initialising them, it would be much easier to document them and keep 
consistent. But maybe I'm missing some important detail
   
   Yeah this is a fair point. Once the tests pass and those comments are 
updated I'm happy to approve.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to