vincbeck commented on code in PR #35160:
URL: https://github.com/apache/airflow/pull/35160#discussion_r1373274314
##########
dev/breeze/src/airflow_breeze/commands/testing_commands.py:
##########
@@ -250,6 +276,35 @@ def _run_tests_in_pool(
skip_docker_compose_down: bool,
):
escaped_tests = [test.replace("[", "\\[") for test in tests_to_run]
+ isolated_test_types = []
+ for isolated_test_type in ISOLATED_TEST_CASES:
+ if isolated_test_type in tests_to_run:
+ isolated_test_types.append(isolated_test_type)
+ tests_to_run.remove(isolated_test_type)
+ fail_tests = False
+ if isolated_test_types:
+ with ci_group(f"Isolated Testing {' '.join(escaped_tests)}"):
+ for isolated_test_type in isolated_test_types:
Review Comment:
```suggestion
```suggestion
isolated_test_types = [isolated_test_type for isolated_test_type in
ISOLATED_TEST_CASES if isolated_test_type in tests_to_run]
fail_tests = False
if isolated_test_types:
with ci_group(f"Isolated Testing {' '.join(escaped_tests)}"):
for isolated_test_type in isolated_test_types:
tests_to_run.remove(isolated_test_type)
```
```
##########
.github/workflows/ci.yml:
##########
@@ -1027,7 +1025,7 @@ jobs:
uses: ./.github/actions/migration_tests
- name: >
Tests:
${{matrix.python-version}}:${{needs.build-info.outputs.parallel-test-types-list-as-string}}
- run: breeze testing tests --run-in-parallel
+ run: breeze testing tests --run-in-parallel --only-run-db-tests
Review Comment:
nit: I like having the verb first (only my opinion :))
```suggestion
run: breeze testing tests --run-in-parallel --run-db-tests-only
```
##########
dev/breeze/src/airflow_breeze/global_constants.py:
##########
@@ -44,7 +44,7 @@
ALLOWED_PYTHON_MAJOR_MINOR_VERSIONS = ["3.8", "3.9", "3.10", "3.11"]
DEFAULT_PYTHON_MAJOR_MINOR_VERSION = ALLOWED_PYTHON_MAJOR_MINOR_VERSIONS[0]
ALLOWED_ARCHITECTURES = [Architecture.X86_64, Architecture.ARM]
-ALLOWED_BACKENDS = ["sqlite", "mysql", "postgres", "mssql"]
+ALLOWED_BACKENDS = ["sqlite", "mysql", "postgres", "mssql", "none"]
Review Comment:
Maybe a comment to explain the `none` value? It might not be straightforward
##########
setup.py:
##########
@@ -310,7 +310,7 @@ def write_version(filename: str = str(AIRFLOW_SOURCES_ROOT
/ "airflow" / "git_ve
# By adding a lot of whitespace separation. This limit can be lifted when
we update our doc to handle
# <section> tags for sections
"docutils<0.17.0",
- "eralchemy2",
+ # "eralchemy2",
Review Comment:
Same
##########
setup.cfg:
##########
@@ -101,7 +101,7 @@ install_requires =
flask-session>=0.4.0
flask-wtf>=0.15
google-re2>=1.0
- graphviz>=0.12
+ #graphviz>=0.12
Review Comment:
Leftover? Or is it intended to test things out?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
