potiuk commented on code in PR #35160: URL: https://github.com/apache/airflow/pull/35160#discussion_r1373384808
########## dev/breeze/src/airflow_breeze/commands/testing_commands.py: ########## @@ -250,6 +276,35 @@ def _run_tests_in_pool( skip_docker_compose_down: bool, ): escaped_tests = [test.replace("[", "\\[") for test in tests_to_run] + isolated_test_types = [] + for isolated_test_type in ISOLATED_TEST_CASES: + if isolated_test_type in tests_to_run: + isolated_test_types.append(isolated_test_type) + tests_to_run.remove(isolated_test_type) + fail_tests = False + if isolated_test_types: + with ci_group(f"Isolated Testing {' '.join(escaped_tests)}"): + for isolated_test_type in isolated_test_types: Review Comment: I decided to do it differently (separate steps in CI) - much nicer looking and generally simpler (I just had to add "excluded test list". ########## setup.cfg: ########## @@ -101,7 +101,7 @@ install_requires = flask-session>=0.4.0 flask-wtf>=0.15 google-re2>=1.0 - graphviz>=0.12 + #graphviz>=0.12 Review Comment: yeah. absolutely -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org