ylnsnv commented on PR #35547:
URL: https://github.com/apache/airflow/pull/35547#issuecomment-1807596113

   > @ylnsnv Overall changes look good to me, just a few minor things. Also, 
can you mention the docs where you found the specific types accepted by OpenAI 
API? just curious :)
   
   First of all, thank you for your feedback! 
   To clarify, my initial observation about the `list[Any]` type being used in 
Airflow's code for OpenAI Operator input prompted me to investigate further.
   
   I didn't find the specific type information in the OpenAI API documentation 
directly. Instead, I referred to the actual implementation of the OpenAI API in 
their codebase. There, I found a [line of 
code](https://github-production-user-asset-6210df.s3.amazonaws.com/42522942/281687312-b15eef98-dcb9-42a4-b828-fba8fa9a47d1.png)
 that clearly indicated the expected type. This discovery led me to open the PR 
to align Airflow's type indications with the actual implementation in the 
OpenAI API.
   
   I'm glad to contribute and ensure our codebase is as accurate and up-to-date 
as possible. Thank you again for your thorough review and for pointing out 
areas that needed clarification. Your input is greatly valued! :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to