eladkal commented on code in PR #35488: URL: https://github.com/apache/airflow/pull/35488#discussion_r1397776679
########## airflow/providers/amazon/provider.yaml: ########## @@ -91,6 +91,7 @@ dependencies: - redshift_connector>=2.0.888 - sqlalchemy_redshift>=0.8.6 - asgiref + - python3-saml Review Comment: I assume testing should be done similar to how we test s3fs extra ? https://github.com/apache/airflow/blob/69bac3fba897f9e7b0af642c97f9af0987a875de/airflow/providers/amazon/aws/fs/s3.py#L48-L56 https://github.com/apache/airflow/blob/4cc98ba6648b4a350f9093c4e22ad6cff87ac5e4/tests/providers/amazon/aws/fs/test_s3.py#L26 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org