vincbeck commented on code in PR #35488:
URL: https://github.com/apache/airflow/pull/35488#discussion_r1399815358


##########
airflow/www/security_manager.py:
##########
@@ -355,3 +347,20 @@ def _is_authorized_category_menu(self, category: str) -> 
Callable:
         return lambda action, resource_pk, user: any(
             
self._get_auth_manager_is_authorized_method(fab_resource_name=item) for item in 
items
         )
+
+    """
+    The following methods are specific to FAB auth manager. They still need to 
be "present" in the main
+    security manager class, but they do nothing.
+    """
+
+    def get_action(self, name: str) -> Action:
+        raise NotImplementedError()

Review Comment:
   I can add one. This is something that should never happen though, that's why 
I did not specify any message but it makes no harm adding one



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to