potiuk commented on PR #35868: URL: https://github.com/apache/airflow/pull/35868#issuecomment-1829892711
> I understand (now) that mssql is needed in the docker for the provider package, which is fail. reverted the last two (functional) commits, leaving the driver and the install options for the docker build scripts like before. Actually after https://github.com/apache/airflow/pull/35924 gets merged, we can reconsider removal of this part. After mergint #35924 - the "install MSSQL" will only install the odbc drivers -we do not need any more special case where we had to build pymssql separately at "system" level. So we **could** remove it if we want. This will cause potential incompatibilities, because the image will not have mssql odbc libraries which were there before, so it **might** break somoene's workflow, however I'd say it's a bit non-core-airflow issue any more and anyone could build their image with those drivers added. We would have to add "Changelog" entry explaining that in https://airflow.apache.org/docs/docker-stack/changelog.html but we've been doing similar changes in the past. In this case it's even better because this is the first "bookworm" image - see the current changelog for 2.8.0 https://github.com/apache/airflow/blob/main/docs/docker-stack/changelog.rst And we are going to move "latest" to use Python 3.11 as well as discussed in devlist thread. So there are more changes that are potentially backwards-incompatible coming, removing mssql odbc library, seems like not a big issue. @Taragolis @jscheffl, others WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
