potiuk commented on code in PR #35868:
URL: https://github.com/apache/airflow/pull/35868#discussion_r1408517163
##########
airflow/migrations/versions/0027_1_10_0_add_time_zone_awareness.py:
##########
@@ -139,11 +139,11 @@ def upgrade():
type_=mysql.TIMESTAMP(fsp=6),
)
else:
- # sqlite and mssql datetime are fine as is. Therefore, not converting
Review Comment:
Yeah. The problem with size here is that it's "all" or "nothing" in case of
migrations (and those are the big ones) . All the rest is "2 minutes" review
:).
So yeah, agree we should - I think - quickly - get to conclusions on how we
should do it and start reviewing/merging what we agreed about.
CC: everyone else who migh have an opinion :) . Maybe also worth to send it
to devlist to raise "importance" of it - might be in the response of the
vote/consensus we had about MSSQL removal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
