potiuk commented on code in PR #35970:
URL: https://github.com/apache/airflow/pull/35970#discussion_r1411847486


##########
dev/README_RELEASE_PROVIDER_PACKAGES.md:
##########
@@ -1029,10 +1029,10 @@ do
 done
 
 # Check which old packages will be removed (you need Python 3.8+ and 
dev/requirements.txt installed)
-python ${AIRFLOW_REPO_ROOT}/dev/provider_packages/remove_old_releases.py 
--directory .
+breeze release-management clean-old-provider-artifacts --directory .

Review Comment:
   Yep. Now when the script is part of breeze it could be improved with rich / 
color output.
   
   It could  print Provider Name, list of found artifacts and "command to run". 
Something like:
   
   * Package: apache-airflow-provider-amazon : 1 version found 8.11.0 
[success]OK[/]
   * Package: apache-airflow-provider-google: 2 versions fondd: 9.10.0, 9.10.1. 
[warning]Removing 9.10.0[/]
      Running:  svn rm ......
   
   It could even use the built-in `--dry-run` feature in `run_command`, this 
way we could get rid of the `--execute` flag
   
   So rather than `--execute` command, the first entry in the 
RELEASE_PROVIDER_PACKAGES docs could be
   
   ```
   breeze release-management clean-old-provider-artifacts --directory . 
--dry-run
   ````
   
   And only then 
   
   ```
   breeze release-management clean-old-provider-artifacts --directory . 
   ````
   
   The `run_command` will automatically use `--dry-run`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to