potiuk commented on code in PR #35970:
URL: https://github.com/apache/airflow/pull/35970#discussion_r1412777390
##########
dev/breeze/src/airflow_breeze/commands/release_management_commands.py:
##########
@@ -1245,10 +1253,7 @@ def clean_old_provider_artifacts(
# Leave only last version from each type
for versioned_file in package_types[:-1]:
command = ["svn", "rm", versioned_file.base +
versioned_file.version + versioned_file.suffix]
- if not execute:
- get_console().print(f"[info]Running command: {command} in
dry run[\]")
- else:
- subprocess.run(command, check=True)
+ subprocess.run(command, check=True)
Review Comment:
The `--dry-run` will only be used automatically here if you use
`run_command` from utils. The `subprocess_run` is stdlib one and in Breeze we
have `airflow_breeze.utils.run_command` that handles all the
"bells-and-whistles" :
* Support for --dry-run passed in the command (automatically)
* Support for --verbose passed in the command (automatically)
* Support for output redirection for parallel commands (not used here)
* Support for groupping command output in CI in a "Foldable" run command
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
