potiuk commented on code in PR #35970:
URL: https://github.com/apache/airflow/pull/35970#discussion_r1412809042
##########
dev/breeze/src/airflow_breeze/utils/common_options.py:
##########
@@ -557,6 +557,13 @@ def _set_default_from_parent(ctx: click.core.Context,
option: click.core.Option,
is_flag=True,
envvar="SKIP_CLEANUP",
)
+
+option_directory = click.option(
+ "--directory",
+ type=str,
Review Comment:
NIT: This one is better as it allows for auto-completion and nicer error
reporting (see what happens when you do not provide it now @amoghrajesh
```suggestion
type=click.Path(exists=True, file_okay=False, dir_okay=True,
resolve_path=True),
required=True,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
