Taragolis commented on code in PR #36079: URL: https://github.com/apache/airflow/pull/36079#discussion_r1416911328
########## airflow/providers/amazon/aws/operators/eks.py: ########## @@ -253,6 +253,7 @@ def __init__( self.fargate_selectors = fargate_selectors or [{"namespace": DEFAULT_NAMESPACE_NAME}] self.fargate_profile_name = fargate_profile_name self.deferrable = deferrable + self.eks_hook = EksHook(aws_conn_id=self.aws_conn_id, region_name=self.region) Review Comment: Small suggestion, maybe we could use `hook` property as we use in other boto3 related hooks, so it become more consistent to other hooks? E.g. ```python @cached_property def hook(self) -> EksHook: return EksHook(aws_conn_id=self.aws_conn_id, region_name=self.region) @property def eks_hook(self): warning.warn( "`eks_hook` property is deprecated and will be removed in the future. " "Please use `hook` property instead.", AirflowProviderDeprecationWarning stacklevel=2, ) return self.eks_hook ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org