Taragolis commented on code in PR #36079:
URL: https://github.com/apache/airflow/pull/36079#discussion_r1416922185
##########
airflow/providers/amazon/aws/operators/eks.py:
##########
@@ -400,9 +400,9 @@ def execute_failed(self, context: Context, event: dict[str,
Any] | None = None)
if event is None:
self.log.info("Trigger error: event is None")
raise AirflowException("Trigger error: event is None")
- elif event["status"] == "delteted":
+ elif event["status"] == "deleted":
self.log.info("Cluster deleted")
- raise event["exception"]
+ raise AirflowException("Error creating cluster")
Review Comment:
```suggestion
raise AirflowException("Error creating cluster")
```
Small suggestion to move raise an error out of the condition block, I guess
`execute_failed` method always expected to raise an error, so just in case
raise an error even if status not None or not "deleted", which I guess not
possible right now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
