potiuk commented on code in PR #35748: URL: https://github.com/apache/airflow/pull/35748#discussion_r1422011496
########## chart/templates/_helpers.yaml: ########## @@ -997,3 +997,27 @@ capabilities: app: keda-operator {{- end }} {{- end }} + +{{- define "kubernetesVersion" -}} +{{ printf "%s" .Capabilities.KubeVersion.Version | trimPrefix "v" }} +{{- end -}} + +{{- define "airflowKerberosContainerArgs" -}} +{{- $kubectl_version := include "kubernetesVersion" . -}} +{{- if and (semverCompare ">=2.8.0" .Values.airflowVersion) (semverCompare "<1.28" $kubectl_version) }} Review Comment: Yes. No need to Add 2.8.0 in this case as we are not using any new feature added in `kerberos` command as I understand ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org