amoghrajesh commented on code in PR #35748:
URL: https://github.com/apache/airflow/pull/35748#discussion_r1432291298


##########
chart/templates/workers/worker-deployment.yaml:
##########
@@ -232,7 +233,13 @@ spec:
           {{- if .Values.workers.command }}
           command: {{ tpl (toYaml .Values.workers.command) . | nindent 12 }}
           {{- end }}
-          {{- if .Values.workers.args }}
+          {{- if and .Values.workers.kerberosSidecar.enabled (semverCompare 
"<1.28" $kubeVersion) }}
+          args:
+            {{ tpl (toYaml .Values.workers.args) . | nindent 12 }} &&

Review Comment:
   I tried something like this:
   ```
             {{- if and .Values.workers.kerberosSidecar.enabled (semverCompare 
"<1.28" $kubeVersion) }}
             args:
               - {{ tpl (toYaml .Values.workers.args) . | nindent 12 }}
               - "&&"
               - "sh"
               - "-c"
               - >
                 echo "EXIT file content" > /opt/kerberos-exit/EXIT
             {{- else if .Values.workers.args }}
             args: {{ tpl (toYaml .Values.workers.args) . | nindent 12 }}
             {{- end }}
   ```
   
   This evaluates to:
   ```
             args:
               - 
               - bash
               - -c
               - |-
                 exec \
                 airflow celery worker
               - "&&"
               - "sh"
               - "-c"
               - >
                 echo "EXIT file content" > /opt/kerberos-exit/EXIT
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to