romsharon98 commented on PR #36374: URL: https://github.com/apache/airflow/pull/36374#issuecomment-1868309042
> The trigger rule dep could change the TI state to skipped without raising this exception, I wonder if we should handle that case too 🤔 > > https://github.com/apache/airflow/blob/95bf5dd620ec996dda834ba13048a77314d6d915/airflow/ti_deps/deps/trigger_rule_dep.py#L285 > > I'm not sure if we handle that for other callbacks As @eladkal commented, I think it should take care by another PR that call the `on_skipped_callback` everywhere the task is skipped and not only if this exception is thrown. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
