jscheffl commented on code in PR #36374:
URL: https://github.com/apache/airflow/pull/36374#discussion_r1438943686
##########
airflow/models/baseoperator.py:
##########
@@ -597,6 +599,8 @@ class derived from this one results in the creation of a
task object,
that it is executed when retries occur.
:param on_success_callback: much like the ``on_failure_callback`` except
that it is executed when the task succeeds.
+ :param on_skipped_callback: much like the ``on_failure_callback`` except
+ that it is executed when skipped occur; this callback will be called
only if AirflowSkipException get raised.
Review Comment:
I'd favor to make it explicit. Many people/starters might not know about
this exception.
```suggestion
:param on_skipped_callback: much like the ``on_failure_callback`` except
that it is executed when skipped occur; this callback will be called
only if AirflowSkipException get raised.
Explicitly it is NOT called if a task is not started to be executed
because of a preceding branching
decision in the DAG or a trigger rule which causes execution to skip
so that the task execution
is never scheduled.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
