josh-fell commented on code in PR #36419:
URL: https://github.com/apache/airflow/pull/36419#discussion_r1437086157
##########
airflow/providers/apache/spark/hooks/spark_submit.py:
##########
@@ -98,10 +98,42 @@ class SparkSubmitHook(BaseHook, LoggingMixin):
def get_ui_field_behaviour(cls) -> dict[str, Any]:
"""Return custom field behaviour."""
return {
- "hidden_fields": ["schema", "login", "password"],
+ "hidden_fields": ["schema", "login", "password", "extra"],
"relabeling": {},
}
+ @classmethod
+ def get_connection_form_widgets(cls) -> dict[str, Any]:
+ """Returns connection widgets to add to connection form."""
+ from flask_appbuilder.fieldwidgets import BS3TextFieldWidget
+ from flask_babel import lazy_gettext
+ from wtforms import StringField
+ from wtforms.validators import Optional, any_of
+
+ return {
+ "queue": StringField(
+ lazy_gettext("YARN queue"),
+ widget=BS3TextFieldWidget(),
+ description="Default YARN queue to use",
+ validators=[Optional()],
+ ),
+ "deploy-mode": StringField(
+ lazy_gettext("Deploy mode"),
+ widget=BS3TextFieldWidget(),
+ description="Must be client or cluster",
+ validators=[any_of(["client", "cluster"])],
+ ),
+ "spark-binary": StringField(
+ lazy_gettext("Spark binary"),
+ widget=BS3TextFieldWidget(),
+ description=f"Must be one of: {',
'.join(ALLOWED_SPARK_BINARIES)}",
+ validators=[any_of(ALLOWED_SPARK_BINARIES)],
Review Comment:
Agreed, separate PR, but there was a [particular
reason](https://github.com/apache/airflow/issues/17193) why `SelectField`
wasn't in the original list of allowed types it seems. The issue is 2 years
old, but obviously we don't want to resurface an old bug. Just a heads up
if/when making the change later.
It would be very useful to have this form field type. (It's used in the
Connection form itself already.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
