shohamy7 commented on PR #36419: URL: https://github.com/apache/airflow/pull/36419#issuecomment-1870649740
@josh-fell Good point! I didn't know about this one. I've checked and saw that it is causing issues with other connections. But I saw that when I add default values, the problem solved. I saw that we already implement this kind of logic in the `VaultHook`. https://github.com/apache/airflow/blob/71314b86cfb73478b929c5728c5b969f6b3caeae/airflow/providers/hashicorp/hooks/vault.py#L380-L386 I will push a fix with default values. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
