jtommi commented on code in PR #36611:
URL: https://github.com/apache/airflow/pull/36611#discussion_r1442737460


##########
docs/apache-airflow/howto/docker-compose/index.rst:
##########
@@ -149,7 +149,7 @@ On **all operating systems**, you need to run database 
migrations and create the
 
 .. code-block:: bash
 
-    docker compose up airflow-init
+    docker compose run airflow-init

Review Comment:
   I'm running this on Windows 11 with Docker Desktop and `docker compose up 
airflow-init` does not initialize the DB, but `docker compose run airflow-init` 
does.
   
   > in addition this service would also use later for services dependencies 
check.
   That will be run anyway by the depends_on of the webserver and scheduler, so 
my change in the doc doesn't influence that.  
   The doc specifically mentions to initialize the DB "Before starting Airflow 
for the first time", so this is a one-time manual process.
   



##########
docs/apache-airflow/howto/docker-compose/index.rst:
##########
@@ -149,7 +149,7 @@ On **all operating systems**, you need to run database 
migrations and create the
 
 .. code-block:: bash
 
-    docker compose up airflow-init
+    docker compose run airflow-init

Review Comment:
   I'm running this on Windows 11 with Docker Desktop and `docker compose up 
airflow-init` does not initialize the DB, but `docker compose run airflow-init` 
does.
   
   > in addition this service would also use later for services dependencies 
check.
   
   That will be run anyway by the depends_on of the webserver and scheduler, so 
my change in the doc doesn't influence that.  
   The doc specifically mentions to initialize the DB "Before starting Airflow 
for the first time", so this is a one-time manual process.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to